Handle when a specifier is not set for a targeted package within setup.py - #25719
Merged
Scott Beddall (scbedd) merged 2 commits intoAug 16, 2022
Merged
Conversation
Scott Beddall (scbedd)
requested review from
Ben Broderick Phillips (benbp) and
Wes Haggard (weshaggard)
as code owners
August 16, 2022 22:05
Laia Patiño (laiapat)
approved these changes
Aug 16, 2022
Scott Beddall (scbedd)
enabled auto-merge (squash)
August 16, 2022 22:23
Laia Patiño (laiapat)
pushed a commit
to laiapat/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
… set for a targeted package within setup.py (Azure#25719)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After merging my refactor PR, I discovered that
azure-ai-mlran into issues with their sphinx build.They depend on
azure-identitywith no version specifier. Without that version specifier, we were hitting an issue where we were Expecting one to be present.This PR updates the behavior so that if we ARE in that situation, we won't force a reinstall if any version is already installed.